Merged
Conversation
whummer
approved these changes
Dec 17, 2025
| case ForwardingState.UNDECIDED: | ||
| self.buffer.append(data) | ||
|
|
||
| if headers := get_headers_from_data_stream(self.buffer): |
Member
There was a problem hiding this comment.
small nitpick: I guess we could reverse the logic with if not ... and return, to reduce the level of indentation. (but really not critical, more a matter of taste / personal preference, so feel free to leave as-is :) )
Contributor
Author
There was a problem hiding this comment.
Yeah, I think it could go either way. I personally find it clearer like this, but if the code grew longer, I'd switch it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the state machine explicit in ForwardingBuffer, and also bumps the minimum Python version to 3.10, since the
matchstatement is used, and not available in 3.9.The minimum backend runtime version of Python for localstack seems to now be 3.13, so for maximum compatibility we should probably align that across all extensions?
(I also bumped the version of this extension as part of this PR.)